BER-71: Rewrite GymDetailViewController in SwiftUIFeature - #363
Open
YHC66 wants to merge 9 commits into
Open
Conversation
baeuke
self-requested a review
April 24, 2025 00:02
baeuke
reviewed
Apr 26, 2025
justinwongeecs
requested changes
Apr 27, 2025
justinwongeecs
requested changes
May 1, 2025
justinwongeecs
left a comment
justinwongeecs
left a comment
Collaborator
There was a problem hiding this comment.
Refactor the overview section into a more generic one that can be suitable for DiningHall, Gym, and Library.
Contributor
Author
A little confused about if I solved it correctly. |
justinwongeecs
requested changes
May 1, 2025
justinwongeecs
requested changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/moon-stone/issue/BER-71/rewrite-gymdetailviewcontroller-in-swiftui
Rewrote GymdetailView into SwiftUI
Tested and ensured the compatibility of dark mode
Screen.Recording.2025-04-18.at.4.31.52.PM.mov